javascript - Need to refactor this JS, not sure where to start -

-

just inherited function dropdown menu , it's ugly sin, , seems pretty fragile in several browsers(mostly older versions of safari), im not sure start, suggestions appreciated. feel need break several smaller functions remove hard coded html(not sure how that)

the offending code:

function mini_cart_populate(){   var order;   $.get('/get_current_order.json',   function(data) {     $('#minicart-thumbnails').html('');     order = data.order;      if (order.order.line_items.length == 1) {        $('#minicart_content').addclass('single');        $('.cart_pulldown').addclass('single');        $('#minicart_footer').addclass('single');     } else {       $('#minicart_content').removeclass('single');       $('.cart_pulldown').removeclass('single');       $('#minicart_footer').removeclass('single');     }     if (order.order.line_items.length > 0) {       $('#cart_pulldown').removeclass('empty_minicart');       $('#minicart_header').show();       $('#minicart_content').show();       $('#minicart_footer').show();       $('.clearboth').show();       (var = 0; < order.order.line_items.length ; ++ ) {         var char_limit = 80;         var variant = data.variant_information[i];         var item_string = "<div class='minicart_item_wrapper'>";         //image string         item_string += "<a href='"+ variant.path +"'><img src='"+ variant.image_url +"'></a>";         //assume title , description items         item_string += "<div class='mini_item_detail'>"+           "<p class='mini_item_description'><strong>"+variant.title+           "</strong>"+"<br/>"+variant.description.slice(0,char_limit)+           (variant.description.slice(char_limit).length > 0 ? "..." : "" ) + "</p>";         //assume items have price         item_string += "<li>"+"$"+math.round(variant.price)+"</li>";         //check variant measurements , foreign sizes; add '|' if there          if (variant.variant_size) { item_string += " | <li>"+variant.variant_size+"</li>"; }         if (variant.foreign_size) { item_string += " | <li>"+variant.foreign_size+"</li>"; }         var delete_button_string = "<div class='cart-item-delete minicart' data-hook='cart_item_delete'>" +            "<a href='javascript:;' class='delete' id='delete_line_item_"+            variant.line_item_id +"' line_item_id='" +            variant.line_item_id + "'>x</a></div></div></div>"          if (window.location.pathname.split("/")[1] == "checkout"){           delete_button_string = '';           }         $('#minicart-thumbnails').append( item_string + delete_button_string )         bind_delete_button();         $('#minicart_info').show();         $('#minicart-thumbnails').show();         }     } else {       $('.cart_pulldown').addclass('empty_minicart');       $('#minicart_info').hide();       $('#minicart-thumbnails').hide();       $("#mini_empty_message").show();       $('#minicart_header').hide();       $('#minicart_content').hide();       $('#minicart_footer').hide();       $('.clearboth').hide();     }      set_product_page_variant_state();      var new_count = order.order.line_items.length + " item";      if (order.order.line_items.length > 1) { new_count += "s" };      $("#mini-item-count").text(new_count);   }).done(function(){      var item_total = parsefloat(order.order.item_total);     var subtotal = item_total.tofixed(2);     $('#minicart_subtotal').text('$' + subtotal);   }) }

i start formatting code , breaking logical sections:

  • the ajax request
  • separate functions dom modifications
  • a function contains loop

so function may start instead:

function mini_cart_populate() {     // find longhand ajax form more readable     $.ajax(         type: "get",         url: "/get_current_order.json"     ).done(current_order); }  function current_order(data) {     var order = data.order;     if (order.order.line_items.length == 1) {         add_single();     } else {         remove_single();     } }  function add_single() {     $('#minicart_content').addclass('single');      $('.cart_pulldown').addclass('single');      $('#minicart_footer').addclass('single'); }  // ...etc, idea

sort out formatting of actual code well: http://jsbeautifier.org/ work you, may have finish yourself. opinions divided on it, think should camelcase variable names in js, if working jquery (as that's jquery functions in code like). find consistency makes js easier read.

you build html jquery, or @ templating solution mustache, or if want sort out, looks comes kind of project full refactor using mvc library (e.g. angular.js or ember.js).

they may seem little daunting @ first, you'll learn better practices in terms of application design , maintainability future projects.


Comments

Post a Comment

Popular posts from this blog

css - Which browser returns the correct result for getBoundingClientRect of an SVG element? -

-
this svg contains rect overflows svg element: <svg id='svg' width='10' height='10'> <rect x='-10' y='-10' width='30' height='30'/> </svg> chrome 28 , opera 12 return getboundingclientrect() svg element width , height of 10. firefox 23 reports width , height of 30. correct? jsfiddle the relevant spec cssom , delegates svg spec if svg element not "have associated css layout box". haven't found definition of "having associated css layout box", correct result seem hinge on definition, getbbox returns 30x30 rect in browsers. this firefox bug fixed now, fix in firefox nightlies , should make through firefox 33 released on 14 october 2014. see bug 530985 details.
Read more

gcc - Calling fftR4() in c from assembly -

-
i trying asm fft implementation www.embeddedsignals.com work. running make gives error: undefined reference fftr4(short*, short*, int) at top of asm have .syntax unified .thumb .global fftr4 .type fftr4, %function and there #define's associate c functions arguments registers followed macros fftr4 function uses. after that, fftr4 called .thumb_func fftr4: stmfd sp!, {r4-r11, lr} mov tmp0, #0 // bit reversed counter mov tmp1, #0 .word 0xf3a2fa92 //rbit r3,r2 //rbit r,n lsl r,#3 and c code follows: void fftr4(short *y, short *x, int n); short x[512]; short y[512]; int i; void loop() { (i=0;i<512;i++) x[i]=0; (i=0;i<512;i=i+8) { x[i+0]=16384; x[i+2]=16384; x[i+4]=-16384; x[i+6]=-16384;} fftr4(y, x, 256); serialusb.println(y[128]); serialusb.println(y[129]); serialusb.println(y[384]); serialusb.println(y[385]); // expected results: //y[128]is 8191; y[129] -8190 y[...
Read more

.htaccess - Matching full URL in RewriteCond -

-
i'm trying block post access site (and return 403), except 2 ip's , 1 url ( http://mydomain.com/about-us/contact-us/ ). here's have: rewritecond %{request_method} post rewritecond %{remote_addr} !=1.2.3.4 rewritecond %{remote_addr} !=4.3.2.1 rewritecond %{request_uri} !^http://mydomain.com/about-us/contact-us/$ rewriterule ^ / [f] these rules allowing access ip properly, contact page still not accessible. i'm not sure i'm using request_uri correctly? i've tried variations relative urls rewritecond %{request_uri} !^/about-us/contact-us$ , rewritecond %{request_uri} !^/about-us/contact-us/$ without luck. what doing wrong please? it looks me rule on file name specific. if relax bit, should work. made few other esthetic tweaks. give try: rewritecond %{request_method} post rewritecond %{remote_addr} !^1.2.3.4 rewritecond %{remote_addr} !^4.3.2.1 rewritecond %{request_uri} !about-us/contact-us rewriterule ^ - [f]
Read more