c++ - Vector with custom objects: crash when I want to use one received with .at method -

-

i have class named cconfig, i'm creating new object:

std::vector< cconfig > docs;  cconfig newfile( "somefile.xml", "root" ); printf("%s", newfile.gettagvalue( "servername" )); // works docs.push_back( newfile );

when i'm getting object .at method

cconfig file = docs.at(0); printf("%s", file.gettagvalue( "servername" )); // crashes

where's problem?

(im sorry if formatting wrong don't use javascript because bandwidth ended , max speed 1kb/s i'll try fix later)

cconfig.h:

class cconfig {     tixmldocument       m_doc;     tixmlelement*       m_proot;     bool                m_bisloaded;  public:                     cconfig                     ( void ) {};                     cconfig                     ( const char * pszfilename, const char * pszrootname );                     ~cconfig                    ( void ) {};  const char*         gettagvalue                 ( const char * psztagname ); const char*         gettagattribute             ( const char * psztagname, const char * pszattributename ); tixmlelement*       getrootelement              ( void )    { return m_proot; }; bool                isavailable                 ( void )    { return m_bisloaded; }; };

cconfig.cpp

#include "cconfig.h"  cconfig::cconfig( const char * pszfilename, const char * pszrootname ) {     m_bisloaded = m_doc.loadfile( pszfilename );     if( m_bisloaded )         m_proot = m_doc.firstchildelement( pszrootname ); }  const char * cconfig::gettagvalue( const char * psztagname ) {     if( m_bisloaded && m_proot )     {         tixmlelement * element = m_proot->firstchildelement( psztagname );         if( element )             return element->gettext();     } }  const char * cconfig::gettagattribute( const char * psztagname, const char * pszattributename ) {     if( m_bisloaded && m_proot )     {         tixmlelement * element = m_proot->firstchildelement( psztagname );         if( element )             return element->attribute( pszattributename );     } }

i'm using tinyxml

your issue pointers old memory. when add item array, copied. later leave scope , original destroyed, ask pointer in copy pointing? still first (now deleted) object's memory. uh-oh.

the simplest fix (while avoiding large copy operations) make m_doc shared pointer (available in standard in c++11, or via boost in c++03). handle rule-of-3 wise. , because underlying memory won't move, m_proot remain valid until last copy has been deleted.


Comments

Post a Comment

Popular posts from this blog

css - Which browser returns the correct result for getBoundingClientRect of an SVG element? -

-
this svg contains rect overflows svg element: <svg id='svg' width='10' height='10'> <rect x='-10' y='-10' width='30' height='30'/> </svg> chrome 28 , opera 12 return getboundingclientrect() svg element width , height of 10. firefox 23 reports width , height of 30. correct? jsfiddle the relevant spec cssom , delegates svg spec if svg element not "have associated css layout box". haven't found definition of "having associated css layout box", correct result seem hinge on definition, getbbox returns 30x30 rect in browsers. this firefox bug fixed now, fix in firefox nightlies , should make through firefox 33 released on 14 october 2014. see bug 530985 details.
Read more

gcc - Calling fftR4() in c from assembly -

-
i trying asm fft implementation www.embeddedsignals.com work. running make gives error: undefined reference fftr4(short*, short*, int) at top of asm have .syntax unified .thumb .global fftr4 .type fftr4, %function and there #define's associate c functions arguments registers followed macros fftr4 function uses. after that, fftr4 called .thumb_func fftr4: stmfd sp!, {r4-r11, lr} mov tmp0, #0 // bit reversed counter mov tmp1, #0 .word 0xf3a2fa92 //rbit r3,r2 //rbit r,n lsl r,#3 and c code follows: void fftr4(short *y, short *x, int n); short x[512]; short y[512]; int i; void loop() { (i=0;i<512;i++) x[i]=0; (i=0;i<512;i=i+8) { x[i+0]=16384; x[i+2]=16384; x[i+4]=-16384; x[i+6]=-16384;} fftr4(y, x, 256); serialusb.println(y[128]); serialusb.println(y[129]); serialusb.println(y[384]); serialusb.println(y[385]); // expected results: //y[128]is 8191; y[129] -8190 y[...
Read more

.htaccess - Matching full URL in RewriteCond -

-
i'm trying block post access site (and return 403), except 2 ip's , 1 url ( http://mydomain.com/about-us/contact-us/ ). here's have: rewritecond %{request_method} post rewritecond %{remote_addr} !=1.2.3.4 rewritecond %{remote_addr} !=4.3.2.1 rewritecond %{request_uri} !^http://mydomain.com/about-us/contact-us/$ rewriterule ^ / [f] these rules allowing access ip properly, contact page still not accessible. i'm not sure i'm using request_uri correctly? i've tried variations relative urls rewritecond %{request_uri} !^/about-us/contact-us$ , rewritecond %{request_uri} !^/about-us/contact-us/$ without luck. what doing wrong please? it looks me rule on file name specific. if relax bit, should work. made few other esthetic tweaks. give try: rewritecond %{request_method} post rewritecond %{remote_addr} !^1.2.3.4 rewritecond %{remote_addr} !^4.3.2.1 rewritecond %{request_uri} !about-us/contact-us rewriterule ^ - [f]
Read more